Both example are targeting to write above.
Once we support the format conversion, the tool will update it automatically without any changes.īenchmarking write command for CBOR/Ion does NOT require format conversion we provide python layer objects and doesn't care about how they are encoded and written into files. We had an enhancement ticket describing this - #234. One thing I want to point out is that ion_binary is compared in the example but it's doing the exact same thing as format ion_text. Overall, the tool is assuming that we had the format conversion functionality already but it doesn't do any conversion work for files.īenchmarking both read and write for JSON/Ion_text with simple files does NOT require format conversion. Yep, these metrics are generated by the tool directly. Since format conversion is left as a TODO, can you explain what is actually happening today in each of your examples in the description? Do those come from an actual execution? #244.īy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. This needs improvement - Benchmark CLI needs pretty printed option log. For example, (simpleion, ion_binary, file) represents that -api is simpleion, -format is ion_binary and -io-type is file.
Right now, the options output in the output table is unclear.
Need more investigation for memory related metrics - Benchmark CLI memory profiling feature enhancement. Due to the potential optimization Python may do, the memory usage metrics might be inaccurate after running different formats multiple execution times. Python amazon/ionbenchmark/ion_benchmark_cli.py write -io-type file -format cbor2 -format ion_binary test_unit_intĬurrently, the tool only profile a memory usage peak.
0 kommentar(er)
